NetTalk Central

Author Topic: 12.60 Header menu DIV mismatch  (Read 3218 times)

Jane

  • Sr. Member
  • ****
  • Posts: 372
  • Expert on nothing with opinions on everything.
    • View Profile
    • Email
12.60 Header menu DIV mismatch
« on: May 22, 2023, 06:58:06 PM »
From the history:  "Fix: Better handling of blank parameters in SetDomains, CreateButton, _DivHeader, _DivFooter"

Is that what I'm seeing?  I now have the border-bottom for the header appearing below the browse or whatever's on the page. 
And on the index page, the default vertical height is gone.

Are there some "blank parameters" somewhere I've forgotten to set?
(Default for app is Div Grid).

Thanks!


« Last Edit: May 22, 2023, 09:25:37 PM by Jane »

Jane

  • Sr. Member
  • ****
  • Posts: 372
  • Expert on nothing with opinions on everything.
    • View Profile
    • Email
Re: 12.60 Header menu DIV mismatch
« Reply #1 on: May 22, 2023, 07:36:18 PM »
Hmmm...  I don't see where this is happening but think this is probably my issue.

12.60 has changed the double drop menu to be a DIV (versus the NAV in 12.59 and earlier) but the closing tag is still for /nav.

« Last Edit: May 22, 2023, 09:26:42 PM by Jane »

Jane

  • Sr. Member
  • ****
  • Posts: 372
  • Expert on nothing with opinions on everything.
    • View Profile
    • Email
Re: 12.60 Header menu DIV mismatch
« Reply #2 on: May 22, 2023, 08:10:35 PM »
I put in a couple of trace statements.
The 'nav' is correctly sent from the procedure, but the IF OMITTED in the class is considering it omitted and injecting the default DIV.

I don't have time tonight to re-install 12.59 again to compare.

 
« Last Edit: May 22, 2023, 09:26:31 PM by Jane »

Jane

  • Sr. Member
  • ****
  • Posts: 372
  • Expert on nothing with opinions on everything.
    • View Profile
    • Email
SOLVED Re: 12.60 Header menu DIV mismatch
« Reply #3 on: May 23, 2023, 07:01:39 AM »
AHA!

It's the old "do what I mean not what I type" trick.  :P

You've got a typo, Bruce.  block should be p_block on line 11279. 
Fixing that fixes my issues.



« Last Edit: May 23, 2023, 07:37:19 AM by Jane »

Bruce

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 11250
    • View Profile
Re: 12.60 Header menu DIV mismatch
« Reply #4 on: May 23, 2023, 09:35:15 PM »
thanks Jane - fixed for the 12.61 build.